linux-kernel - Re: [RESEND PATCH] soc: amlogic: add missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <c88b9f23-6d69-50f4-4a65-9e4fcd240beb@baylibre.com>
Date:   Mon, 4 Feb 2019 10:30:41 +0100
From:   Neil Armstrong <narmstrong@...libre.com>
To:     wen yang <yellowriver2010@...mail.com>,
        "khilman@...libre.com" <khilman@...libre.com>
Cc:     "linux-amlogic@...ts.infradead.org" 
        <linux-amlogic@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [RESEND PATCH] soc: amlogic: add missing of_node_put()

Hi,

On 03/02/2019 06:41, wen yang wrote:
> The call to of_parse_phandle returns a node pointer with refcount
> incremented thus it must be explicitly decremented here after the last
> usage.
> 

Missing a Fixes tag.

> Signed-off-by: Wen Yang <yellowriver2010@...mail.com>
> Cc: Kevin Hilman <khilman@...libre.com>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-amlogic@...ts.infradead.org
> Cc: linux-kernel@...r.kernel.org
> ---
>  drivers/soc/amlogic/meson-canvas.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/amlogic/meson-canvas.c b/drivers/soc/amlogic/meson-canvas.c
> index fce33ca..87a6c6e 100644
> --- a/drivers/soc/amlogic/meson-canvas.c
> +++ b/drivers/soc/amlogic/meson-canvas.c
> @@ -57,9 +57,12 @@ struct meson_canvas *meson_canvas_get(struct device *dev)
>  		return ERR_PTR(-ENODEV);
>  
>  	canvas_pdev = of_find_device_by_node(canvas_node);
> -	if (!canvas_pdev)
> +	if (!canvas_pdev) {
> +		of_node_put(canvas_node);
>  		return ERR_PTR(-EPROBE_DEFER);
> +	}
>  
> +	of_node_put(canvas_node);
>  	return dev_get_drvdata(&canvas_pdev->dev);
>  }
>  EXPORT_SYMBOL_GPL(meson_canvas_get);
> 

Apart the missing Fixes tag :

Reviewed-by: Neil Armstrong <narmstrong@...libre.com>

Neil