linux-kernel - Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <alpine.LFD.2.21.1902041056190.1862@schleppi.aag-de.ibmmobiledemo.com>
Date:   Mon, 4 Feb 2019 11:01:40 +0100 (CET)
From:   Sebastian Ott <sebott@...ux.ibm.com>
To:     Tony Krowiak <akrowiak@...ux.ibm.com>
cc:     linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        oberpar@...ux.ibm.com, freude@...ux.ibm.com, pmorel@...ux.ibm.com,
        pasic@...ux.ibm.com, cohuck@...hat.com
Subject: Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI
 command

On Thu, 31 Jan 2019, Tony Krowiak wrote:
> On 1/30/19 1:32 PM, Sebastian Ott wrote:
> > On Wed, 30 Jan 2019, Tony Krowiak wrote:
> >> +++ b/drivers/s390/cio/chsc.h
> >> @@ -9,6 +9,7 @@
> >>   #include <asm/chsc.h>
> >>   #include <asm/schid.h>
> >>   #include <asm/qdio.h>
> >> +#include <asm/ap.h>
> > 
> > This should be moved to chsc.c
> 
> I can do that, but I'm curious why.

You only need to include ap.h because of the ap_bus_cfg_chg definition and
you only use that in chsc.c . Other users of chsc.h don't call that
function.

Regards,
Sebastian