linux-kernel - RE: [PATCH] scsi: aacraid: clean up some indentation and formatting issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <BL0PR11MB289749AD4D35250355C72423FE6D0@BL0PR11MB2897.namprd11.prod.outlook.com>
Date:   Mon, 4 Feb 2019 10:37:02 +0000
From:   <Mahesh.Rajashekhara@...rochip.com>
To:     <aacraid@...rosemi.com>, <jejb@...ux.ibm.com>,
        <martin.petersen@...cle.com>, <linux-scsi@...r.kernel.org>
CC:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] scsi: aacraid: clean up some indentation and formatting
 issues

Acked-by: Mahesh Rajashekhara <mahesh.rajashekhara@...rochip.com>

---------- Forwarded message ----------
From: Colin King <mailto:colin.king@...onical.com>
Date: Feb 2, 2019 2:41 AM
Subject: [PATCH] scsi: aacraid: clean up some indentation and formatting issues
To: Adaptec OEM Raid Solutions <mailto:aacraid@...rosemi.com>,"James E . J . Bottomley" <mailto:jejb@...ux.ibm.com>,"Martin K . Petersen" <mailto:martin.petersen@...cle.com>,linux-scsi@...r.kernel.org
Cc: mailto:kernel-janitors@...r.kernel.org,linux-kernel@...r.kernel.org
EXTERNAL EMAIL


From: Colin Ian King <mailto:colin.king@...onical.com>

There are several issues with badly indented statements. Fix these
and clean up the formatting.

Signed-off-by: Colin Ian King <mailto:colin.king@...onical.com>
---
 drivers/scsi/aacraid/commsup.c | 25 +++++++++++++------------
 drivers/scsi/aacraid/linit.c   |  3 +--
 drivers/scsi/aacraid/src.c     |  2 +-
 3 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c
index d5a6aa9676c8..0bdc6b0f725f 100644
--- a/drivers/scsi/aacraid/commsup.c
+++ b/drivers/scsi/aacraid/commsup.c
@@ -1376,18 +1376,19 @@ static void aac_handle_aif(struct aac_dev * dev, struct fib * fibptr)

        container = 0;
 retry_next:
-       if (device_config_needed == NOTHING)
-       for (; container < dev->maximum_num_containers; ++container) {
-               if ((dev->fsa_dev[container].config_waiting_on == 0) &&
-                       (dev->fsa_dev[container].config_needed != NOTHING) &&
-                       time_before(jiffies, dev->fsa_dev[container].config_waiting_stamp + AIF_SNIFF_TIMEOUT)) {
-                       device_config_needed =
-                               dev->fsa_dev[container].config_needed;
-                       dev->fsa_dev[container].config_needed = NOTHING;
-                       channel = CONTAINER_TO_CHANNEL(container);
-                       id = CONTAINER_TO_ID(container);
-                       lun = CONTAINER_TO_LUN(container);
-                       break;
+       if (device_config_needed == NOTHING) {
+               for (; container < dev->maximum_num_containers; ++container) {
+                       if ((dev->fsa_dev[container].config_waiting_on == 0) &&
+                           (dev->fsa_dev[container].config_needed != NOTHING) &&
+                           time_before(jiffies, dev->fsa_dev[container].config_waiting_stamp + AIF_SNIFF_TIMEOUT)) {
+                               device_config_needed =
+                                       dev->fsa_dev[container].config_needed;
+                               dev->fsa_dev[container].config_needed = NOTHING;
+                               channel = CONTAINER_TO_CHANNEL(container);
+                               id = CONTAINER_TO_ID(container);
+                               lun = CONTAINER_TO_LUN(container);
+                               break;
+                       }
                }
        }
        if (device_config_needed == NOTHING)
diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
index 7e56a11836c1..e977b459f823 100644
--- a/drivers/scsi/aacraid/linit.c
+++ b/drivers/scsi/aacraid/linit.c
@@ -852,8 +852,7 @@ static u8 aac_eh_tmf_hard_reset_fib(struct aac_hba_map_info *info,

        address = (u64)fib->hw_error_pa;
        rst->error_ptr_hi = cpu_to_le32((u32)(address >> 32));
-       rst->error_ptr_lo = cpu_to_le32
-               ((u32)(address & 0xffffffff));
+       rst->error_ptr_lo = cpu_to_le32((u32)(address & 0xffffffff));
        rst->error_length = cpu_to_le32(FW_ERROR_BUFFER_SIZE);
        fib->hbacmd_size = sizeof(*rst);

diff --git a/drivers/scsi/aacraid/src.c b/drivers/scsi/aacraid/src.c
index 8377aec0649d..97bb9e9d201c 100644
--- a/drivers/scsi/aacraid/src.c
+++ b/drivers/scsi/aacraid/src.c
@@ -1157,7 +1157,7 @@ static int aac_src_soft_reset(struct aac_dev *dev)
                dev_err(&dev->pdev->dev, "%s: %s status = %d", __func__,
                        state_str[state], rc);

-return rc;
+       return rc;
 }
 /**
  *  aac_srcv_init      -       initialize an SRCv card
--
2.20.1