linux-kernel - Re: [PATCH V4 01/13] perf/core, x86: Add PERF_SAMPLE_DATA_PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 Feb 2019 11:54:09 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     "Liang, Kan" <kan.liang@...ux.intel.com>
Cc:     "Kirill A. Shutemov" <kirill@...temov.name>, acme@...nel.org,
        tglx@...utronix.de, mingo@...hat.com, linux-kernel@...r.kernel.org,
        eranian@...gle.com, jolsa@...hat.com, namhyung@...nel.org,
        ak@...ux.intel.com, luto@...capital.net,
        Vlastimil Babka <vbabka@...e.cz>,
        Will Deacon <will.deacon@....com>
Subject: Re: [PATCH V4 01/13] perf/core, x86: Add PERF_SAMPLE_DATA_PAGE_SIZE

On Fri, Feb 01, 2019 at 11:16:51AM -0500, Liang, Kan wrote:

> > 	if (p4d_large(*p4d)) {
> 
> This one looks like x86 specific?

> > 	if (pud_large(*pud)) {

> > 	if (pmd_large(*pmd)) {

Kirill did indeed note that p*_large() isn't universally availale (but
there's definitely !x86 archs that have them). He also said it would
probably make sense to have them universally available and might help
clean up mm/gup.c a little.

A quick grep shows that: ARM, PowerPC, S390, Sparc and x86 have
'pmd_large'.

Anyway; it probably makes sense (and shouldn't be too hard) to fix up
all architectures to provide this.