linux-kernel - Re: [RFC/PATCH 00/14] perf record: Add support to store data in directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 Feb 2019 14:29:56 +0300
From:   Alexey Budankov <alexey.budankov@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Jiri Olsa <jolsa@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Stephane Eranian <eranian@...gle.com>
Subject: Re: [RFC/PATCH 00/14] perf record: Add support to store data in
 directory

On 04.02.2019 13:36, Jiri Olsa wrote:
> On Mon, Feb 04, 2019 at 01:12:11PM +0300, Alexey Budankov wrote:
>>
>> Hi,
>>
>> On 03.02.2019 18:30, Jiri Olsa wrote:
>>> hi,
>>> this patchset adds the --dir option to record command (and all
>>> the other record command that overload cmd_record) that allows
>>> the data to be stored in directory with multiple data files.
>>>
>>> It's next step for multiple threads implementation in record.
>>> It's now possible to make directory data via --dir option, like:
>>>
>>>   $ perf record --dir perf bench sched messaging
>>
>> Is it possible to name data directory differently from perf.data 
>> e.g. using --output option, like this?
>>
>>   $ perf record --output result_1 --dir perf bench sched messaging
> 
> 
> yep, it's taken into account:
> 
> [jolsa@...va perf]$ ./perf record --output result_1 --dir ./perf bench sched messaging
> Couldn't synthesize bpf events.
> # Running 'sched/messaging' benchmark:
> # 20 sender and receiver processes per group
> # 10 groups == 400 processes run
> 
>      Total time: 0.177 [sec]
> [ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 0.316 MB result_1 (7225 samples) ]
> 
> [jolsa@...va perf]$ ll result_1/
> total 348
> -rw-------. 1 jolsa jolsa 27624 Feb  4 11:35 data.0
> -rw-------. 1 jolsa jolsa 56672 Feb  4 11:35 data.1
> -rw-------. 1 jolsa jolsa 30824 Feb  4 11:35 data.2
> -rw-------. 1 jolsa jolsa 49136 Feb  4 11:35 data.3
> -rw-------. 1 jolsa jolsa 22712 Feb  4 11:35 data.4
> -rw-------. 1 jolsa jolsa 53392 Feb  4 11:35 data.5
> -rw-------. 1 jolsa jolsa 43352 Feb  4 11:35 data.6
> -rw-------. 1 jolsa jolsa 46688 Feb  4 11:35 data.7
> -rw-------. 1 jolsa jolsa  9068 Feb  4 11:35 header

Awesome. What do you think about having it like this:

  $ perf record --output result_1.data ... - writes data to a file

  $ perf record --dir result_1 ... - or even
  $ perf record --output_dir result_1 ... - writes data into a directory

IMHO, this interface is simpler for a user.

Thanks,
Alexey

> 
> jirka
>