linux-kernel - [PATCH 0/3] perf tools: Move ipc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190204141808.23031-1-jolsa@kernel.org>
Date:   Mon,  4 Feb 2019 15:18:05 +0100
From:   Jiri Olsa <jolsa@...nel.org>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Jin Yao <yao.jin@...ux.intel.com>,
        Kan Liang <kan.liang@...ux.intel.com>
Subject: [PATCH 0/3] perf tools: Move ipc_symbol computation to resort

hi,
currently the we make annotation for ipc column during the
entry display, already outside the progress bar scope, so
it appears like perf report is stuck.

You can see that on following example (with perf.data big enough):
     $ perf record -b ...
     $ perf report -s symbol

The report TUI code will appear stuck when scrolling down,
because annotation are computed at that time. For --stdio,
the output will be displayed noticeably more slowly, than
with the fix.

There's no functional change, I'm just moving the annotation
retrieval to the resort phase, so all the data are ready for
display.

thanks,
jirka


---
Jiri Olsa (3):
      perf tools: Add argument to hists__resort_cb_t callback
      perf tools: Add perf_evsel__output_resort_cb function
      perf tools: Move symbol annotation to resort

 tools/perf/builtin-c2c.c    |  8 ++++----
 tools/perf/builtin-report.c | 21 +++++++++++++++++++--
 tools/perf/util/hist.c      | 19 +++++++++++++------
 tools/perf/util/hist.h      |  4 +++-
 tools/perf/util/sort.c      |  7 -------
 5 files changed, 39 insertions(+), 20 deletions(-)