linux-kernel - Re: [PATCH v4 09/16] block: sed-opal: split generation of bytestring header and content

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190204144811.GI31132@infradead.org>
Date:   Mon, 4 Feb 2019 06:48:11 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     David Kozub <zub@...ux.fjfi.cvut.cz>
Cc:     Jens Axboe <axboe@...nel.dk>,
        Jonathan Derrick <jonathan.derrick@...el.com>,
        Scott Bauer <sbauer@...donthack.me>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jonas Rabenstein <jonas.rabenstein@...dium.uni-erlangen.de>
Subject: Re: [PATCH v4 09/16] block: sed-opal: split generation of bytestring
 header and content

> +	start = &cmd->cmd[cmd->pos];
> +	return start;

No need for the local start variable here, just return the computed
address directly.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>