linux-kernel - Re: [PATCH REGRESSION] Revert "ath10k: add quiet mode support for QCA6174/QCA9377"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190204164254.86E0860734@smtp.codeaurora.org>
Date:   Mon,  4 Feb 2019 16:42:54 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Brian Norris <briannorris@...omium.org>
Cc:     ath10k@...ts.infradead.org, linux-wireless@...r.kernel.org,
        <linux-kernel@...r.kernel.org>,
        Brian Norris <briannorris@...omium.org>,
        Yu Wang <yyuwang@...eaurora.org>,
        Rakesh Pillai <pillair@...eaurora.org>,
        Govind Singh <govinds@...eaurora.org>, stable@...r.kernel.org
Subject: Re: [PATCH REGRESSION] Revert "ath10k: add quiet mode support for
 QCA6174/QCA9377"

Brian Norris <briannorris@...omium.org> wrote:

> This reverts commit cfb353c0dc058bc1619cc226d3cbbda1f360bdd3.
> 
> WCN3990 firmware does not yet implement this feature, and so it crashes
> like this:
> 
>   fatal error received: err_qdi.c:456:EX:wlan_process:1:WLAN RT:207a:PC=b001b4f0
> 
> This feature can be re-implemented with a proper service bitmap or other
> feature-discovery mechanism in the future. But it should not break
> working boards.
> 
> Fixes: cfb353c0dc05 ("ath10k: add quiet mode support for QCA6174/QCA9377")
> Cc: Yu Wang <yyuwang@...eaurora.org>
> Cc: Rakesh Pillai <pillair@...eaurora.org>
> Cc: Govind Singh <govinds@...eaurora.org>
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Brian Norris <briannorris@...omium.org>

This regression should be fixed by (which is in v4.20):

53884577fbce ath10k: skip sending quiet mode cmd for WCN3990

So this revert should not be needed anymore and I'll drop this.

-- 
https://patchwork.kernel.org/patch/10672903/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches