linux-kernel - Re: [PATCH 1/7] thermal: mediatek: fix register index error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6496b13f-57e4-af86-bb59-91a4705d91b0@gmail.com>
Date:   Mon, 4 Feb 2019 18:24:08 +0100
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     michael.kao@...iatek.com, =Zhang Rui <rui.zhang@...el.com>,
        =Eduardo Valentin <edubezval@...il.com>,
        =Daniel Lezcano <daniel.lezcano@...aro.org>,
        =Rob Herring <robh+dt@...nel.org>,
        =Mark Rutland <mark.rutland@....com>
Cc:     linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, srv_heupstream@...iatek.com
Subject: Re: [PATCH 1/7] thermal: mediatek: fix register index error



On 01/02/2019 08:38, michael.kao@...iatek.com wrote:
> From: Michael Kao <michael.kao@...iatek.com>
> 
> The index of msr and adcpnp should match the sensor
> which belongs to the selected bank in the for loop.
> 

If I get that right, this fixes
b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.")

So please add a fixes tag to the commit.

Thanks,
Matthias

> Signed-off-by: Michael Kao <michael.kao@...iatek.com>
> ---
>  drivers/thermal/mtk_thermal.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
> index 0691f26..f646436 100644
> --- a/drivers/thermal/mtk_thermal.c
> +++ b/drivers/thermal/mtk_thermal.c
> @@ -431,7 +431,8 @@ static int mtk_thermal_bank_temperature(struct mtk_thermal_bank *bank)
>  	u32 raw;
>  
>  	for (i = 0; i < conf->bank_data[bank->id].num_sensors; i++) {
> -		raw = readl(mt->thermal_base + conf->msr[i]);
> +		raw = readl(mt->thermal_base +
> +			    conf->msr[conf->bank_data[bank->id].sensors[i]]);
>  
>  		temp = raw_to_mcelsius(mt,
>  				       conf->bank_data[bank->id].sensors[i],
> @@ -568,7 +569,8 @@ static void mtk_thermal_init_bank(struct mtk_thermal *mt, int num,
>  
>  	for (i = 0; i < conf->bank_data[num].num_sensors; i++)
>  		writel(conf->sensor_mux_values[conf->bank_data[num].sensors[i]],
> -		       mt->thermal_base + conf->adcpnp[i]);
> +		       mt->thermal_base +
> +		       conf->adcpnp[conf->bank_data[num].sensors[i]]);
>  
>  	writel((1 << conf->bank_data[num].num_sensors) - 1,
>  	       mt->thermal_base + TEMP_MONCTL0);
>