linux-kernel - RE: [PATCH] media: staging/intel-ipu3: Implement lock for stream on/off operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 4 Feb 2019 17:43:30 +0000
From:   "Mani, Rajmohan" <rajmohan.mani@...el.com>
To:     Sakari Ailus <sakari.ailus@...ux.intel.com>
CC:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Jacopo Mondi <jacopo@...ndi.org>,
        "Qiu, Tian Shu" <tian.shu.qiu@...el.com>,
        "Cao, Bingbu" <bingbu.cao@...el.com>,
        "Zhi@...sikivi.fi.intel.com" <Zhi@...sikivi.fi.intel.com>,
        "Zhi, Yong" <yong.zhi@...el.com>,
        "hverkuil@...all.nl" <hverkuil@...all.nl>,
        "tfiga@...omium.org" <tfiga@...omium.org>
Subject: RE: [PATCH] media: staging/intel-ipu3: Implement lock for stream
 on/off operations

Hi Sakari,

[snip]

> > > > >  fail_stop_pipeline:
> > > > > @@ -543,6 +546,8 @@ static void ipu3_vb2_stop_streaming(struct
> > > > vb2_queue *vq)
> > > > >  		dev_err(&imgu->pci_dev->dev,
> > > > >  			"failed to stop subdev streaming\n");
> > > > >
> > > > > +	mutex_lock(&imgu->streaming_lock);
> > > > > +
> > > > >  	/* Was this the first node with streaming disabled? */
> > > > >  	if (imgu->streaming && ipu3_all_nodes_streaming(imgu, node)) {
> > > > >  		/* Yes, really stop streaming now */ @@ -552,6 +557,7 @@
> > > > static
> > > > > void ipu3_vb2_stop_streaming(struct vb2_queue *vq)
> > > > >  			imgu->streaming = false;
> > > > >  	}
> > > > >
> > > > > +	mutex_unlock(&imgu->streaming_lock);
> > > > >  	ipu3_return_all_buffers(imgu, node, VB2_BUF_STATE_ERROR);
> >
> > I'd also call ipu3_return_all_buffers() before releasing the lock: in
> > principle the user may have queued new buffers on the devices before
> > the driver marks the buffers as faulty.
> >

Ack
(Somehow I missed this comment.)

[snip]