linux-kernel - Re: [PATCH v4 2/6] remoteproc/mediatek: add SCP support for mt8183

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc1407f1-c236-f0af-a6c1-366aeac259f4@gmail.com>
Date:   Mon, 4 Feb 2019 19:02:17 +0100
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Matthias Kaehlcke <mka@...omium.org>,
        Pi-Hsun Shih <pihsun@...omium.org>
Cc:     Erin Lo <erin.lo@...iatek.com>,
        Nicolas Boichat <drinkcat@...omium.org>,
        Ohad Ben-Cohen <ohad@...ery.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM" 
        <linux-remoteproc@...r.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH v4 2/6] remoteproc/mediatek: add SCP support for mt8183



On 02/02/2019 01:17, Matthias Kaehlcke wrote:
> Hi Pi-Hsun,
> 
> a few comments inline.
> 
> It's the first time I dabble into remoteproc, I don't claim to have a
> complete understanding of the driver at this point ;-)
> 
> On Thu, Jan 31, 2019 at 05:31:27PM +0800, Pi-Hsun Shih wrote:
>> From: Erin Lo <erin.lo@...iatek.com>
>>
>> Provide a basic driver to control Cortex M4 co-processor
>>
>> Signed-off-by: Erin Lo <erin.lo@...iatek.com>
>> Signed-off-by: Nicolas Boichat <drinkcat@...omium.org>
>> ---
>> Changes from v3:
>>  - Fix some issue found by checkpatch.
>>  - Make writes aligned in scp_ipi_send.
>>
>> Changes from v2:
>>  - Squash patch 3 from v2 (separate the ipi interface) into this patch.
>>  - Remove unused name argument from scp_ipi_register.
>>  - Add scp_ipi_unregister for proper cleanup.
>>  - Move IPI ids in sync with firmware.
>>  - Add mb() in proper place, and correctly clear the run->signaled.
>>
>> Changes from v1:
>>  - Extract functions and rename variables in mtk_scp.c.
>> ---
>>  drivers/remoteproc/Kconfig            |   9 +
>>  drivers/remoteproc/Makefile           |   1 +
>>  drivers/remoteproc/mtk_common.h       |  73 +++++
>>  drivers/remoteproc/mtk_scp.c          | 441 ++++++++++++++++++++++++++
>>  drivers/remoteproc/mtk_scp_ipi.c      | 157 +++++++++
>>  include/linux/platform_data/mtk_scp.h | 135 ++++++++
>>  6 files changed, 816 insertions(+)
>>  create mode 100644 drivers/remoteproc/mtk_common.h
>>  create mode 100644 drivers/remoteproc/mtk_scp.c
>>  create mode 100644 drivers/remoteproc/mtk_scp_ipi.c
>>  create mode 100644 include/linux/platform_data/mtk_scp.h
>>
>> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
>> index f0abd260804473..ee0bda23768938 100644
>> --- a/drivers/remoteproc/Kconfig
>> +++ b/drivers/remoteproc/Kconfig
>> @@ -22,6 +22,15 @@ config IMX_REMOTEPROC
>>  
>>  	  It's safe to say N here.
>>  
>> +config MTK_SCP
>> +        tristate "Mediatek SCP support"
>> +        depends on ARCH_MEDIATEK
>> +        help
>> +          Say y here to support Mediatek's SCP (Cortex M4
>> +          on MT8183) via the remote processor framework.
> 
> It would be good to spell out SCP somewhere, e.g.
> 
> "... support Mediatek's system control processor (SCP) via ..."
> 
> the example is less important IMO, though it's prefectly fine if you
> can still squeeze it in ;-)
> 

In which way is this different from
drivers/soc/mediatek/mtk-scpsys.c ?

Regards,
Matthias (the other one ;)