linux-kernel - Re: [PATCH v6 0/5] sched/deadline: fix cpusets bandwidth accounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190205091843.GF30905@localhost.localdomain>
Date:   Tue, 5 Feb 2019 10:18:43 +0100
From:   Juri Lelli <juri.lelli@...hat.com>
To:     Waiman Long <longman@...hat.com>
Cc:     Peter Zijlstra <peterz@...radead.org>, mingo@...hat.com,
        rostedt@...dmis.org, linux-kernel@...r.kernel.org,
        luca.abeni@...tannapisa.it, claudio@...dence.eu.com,
        tommaso.cucinotta@...tannapisa.it, bristot@...hat.com,
        mathieu.poirier@...aro.org, lizefan@...wei.com,
        cgroups@...r.kernel.org, tj@...nel.org
Subject: Re: [PATCH v6 0/5] sched/deadline: fix cpusets bandwidth accounting

On 04/02/19 13:45, Waiman Long wrote:
> On 02/04/2019 07:18 AM, Peter Zijlstra wrote:
> > On Mon, Feb 04, 2019 at 10:02:11AM +0100, Juri Lelli wrote:
> >> On 18/01/19 17:46, Juri Lelli wrote:
> >>> On 18/01/19 08:17, Tejun Heo wrote:
> >>>> On Thu, Jan 17, 2019 at 09:47:34AM +0100, Juri Lelli wrote:
> >>>>> Hi,
> >>>>>
> >>>>> v6 of a series of patches, originally authored by Mathieu, with the intent
> >>>>> of fixing a long standing issue of SCHED_DEADLINE bandwidth accounting.
> >>>>> As originally reported by Steve [1], when hotplug and/or (certain)
> >>>>> cpuset reconfiguration operations take place, DEADLINE bandwidth
> >>>>> accounting information is lost since root domains are destroyed and
> >>>>> recreated.
> >>>>>
> >>>>> Mathieu's approach is based on restoring bandwidth accounting info on
> >>>>> the newly created root domains by iterating through the (DEADLINE) tasks
> >>>>> belonging to the configured cpuset(s).
> >>>>>
> >>>>> Apart from some minor refactoring needed to rebase the set on top of
> >>>>> Waiman Long's cpuset for cgroup series (now mainline), two changes worth
> >>>>> of notice:
> >>>> Generally looks good to me but can you please ask Waiman to take a
> >>>> look?
> >>> Argh! I should have cc-ed him in the first instance.
> >>>
> >>> Thanks for reviewing.
> >>>
> >>> Waiman, do you see anything wrong with this series? Thanks!
> >>>
> >>> https://lore.kernel.org/lkml/20190117084739.17078-1-juri.lelli@redhat.com/
> >> Ping?
> > Basically looks OK to me; wlthough I think I prefer the callback_lock /
> > rq->lock ordering to be the other way around.
> >
> > Waiman, you OK with this one?
> 
> Sorry for the late reply. I reviewed the patchset and don't see anything
> wrong with it. However, my knowledge of the internal operation of the
> deadline scheduler is limited.

Thanks for reviewing!