linux-kernel - Re: compile error at sun6i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190205095216.f2fg5vjvqqhgs6as@valkosipuli.retiisi.org.uk>
Date:   Tue, 5 Feb 2019 11:52:16 +0200
From:   Sakari Ailus <sakari.ailus@....fi>
To:     Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc:     Yong Deng <yong.deng@...ewell.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Maxime Ripard <maxime.ripard@...tlin.com>,
        Chen-Yu Tsai <wens@...e.org>, linux-media@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Niklas Söderlund 
        <niklas.soderlund@...natech.se>
Subject: Re: compile error at sun6i_video

Hi Morimoto-san,

On Tue, Feb 05, 2019 at 03:38:29PM +0900, Kuninori Morimoto wrote:
> 
> Hi MultiMedia ML
> 
> I got below compile error at SH.
> 
>   ...
>   CC      drivers/tty/tty_io.o
> /opt/RB02197/home/morimoto/save/WORK/linux/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c: In function 'sun6i_video_start_streaming':
> /opt/RB02197/home/morimoto/save/WORK/linux/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c:141:29: error: passing argument 1 of 'media_pipeline_start' from incompatible pointer type [-Werror=incompatible-pointer-types]
>   ret = media_pipeline_start(&video->vdev.entity, &video->vdev.pipe);
>                              ^~~~~~~~~~~~~~~~~~~
> In file included from /opt/RB02197/home/morimoto/save/WORK/linux/include/media/media-device.h:26,
>                  from /opt/RB02197/home/morimoto/save/WORK/linux/include/media/v4l2-device.h:24,
>                  from /opt/RB02197/home/morimoto/save/WORK/linux/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c:10:
> /opt/RB02197/home/morimoto/save/WORK/linux/include/media/media-entity.h:1030:84: note: expected 'struct media_pad *' but argument is of type 'struct media_entity *'
>  __must_check int media_pipeline_start(struct media_pad *pad,
>                                                                                     ^  
> /opt/RB02197/home/morimoto/save/WORK/linux/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c:205:22: error: passing argument 1 of 'media_pipeline_stop' from incompatible pointer type [-Werror=incompatible-pointer-types]
>   media_pipeline_stop(&video->vdev.entity);
>                       ^~~~~~~~~~~~~~~~~~~
> In file included from /opt/RB02197/home/morimoto/save/WORK/linux/include/media/media-device.h:26,
>                  from /opt/RB02197/home/morimoto/save/WORK/linux/include/media/v4l2-device.h:24,
>                  from /opt/RB02197/home/morimoto/save/WORK/linux/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c:10:
> /opt/RB02197/home/morimoto/save/WORK/linux/include/media/media-entity.h:1055:44: note: expected 'struct media_pad *' but argument is of type 'struct media_entity *'
>  void media_pipeline_stop(struct media_pad *pad);
>                           ~~~~~~~~~~~~~~~~~~^~~
> /opt/RB02197/home/morimoto/save/WORK/linux/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c: In function 'sun6i_video_stop_streaming':
> /opt/RB02197/home/morimoto/save/WORK/linux/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c:229:22: error: passing argument 1 of 'media_pipeline_stop' from incompatible pointer type [-Werror=incompatible-pointer-types]
>   media_pipeline_stop(&video->vdev.entity);
>                       ^~~~~~~~~~~~~~~~~~~
> In file included from /opt/RB02197/home/morimoto/save/WORK/linux/include/media/media-device.h:26,
>                  from /opt/RB02197/home/morimoto/save/WORK/linux/include/media/v4l2-device.h:24,
>                  from /opt/RB02197/home/morimoto/save/WORK/linux/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c:10:
> /opt/RB02197/home/morimoto/save/WORK/linux/include/media/media-entity.h:1055:44: note: expected 'struct media_pad *' but argument is of type 'struct media_entity *'
>  void media_pipeline_stop(struct media_pad *pad);
>                           ~~~~~~~~~~~~~~~~~~^~~

Do you have the patches Niklas's v4l2/mux (or my vc) branch in your tree?
They change a few things on the way and drivers need to be converted.
Drivers that have been added since the patches were written do need to be
converted as well, and I suppose the sun6i_video driver is one of them.

Cc Niklas.

-- 
Kind regards,

Sakari Ailus