linux-kernel - Re: [PATCH 01/22] x86/fpu: Remove fpu->initialized usage in __fpu__restore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190205100653.2t6junknrf3g4qq7@linutronix.de>
Date:   Tue, 5 Feb 2019 11:08:16 +0100
From:   Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:     Borislav Petkov <bp@...en8.de>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org,
        Andy Lutomirski <luto@...nel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        kvm@...r.kernel.org, "Jason A. Donenfeld" <Jason@...c4.com>,
        Rik van Riel <riel@...riel.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>
Subject: Re: [PATCH 01/22] x86/fpu: Remove fpu->initialized usage in
 __fpu__restore_sig()

On 2019-01-14 17:24:00 [+0100], Borislav Petkov wrote:
> > @@ -315,40 +313,33 @@ static int __fpu__restore_sig(void __user *buf, void __user *buf_fx, int size)
…
> > -			sanitize_restored_xstate(tsk, &env, xfeatures, fx_only);
> > +			sanitize_restored_xstate(state, &env,
> > +						 xfeatures, fx_only);
> 
> Just let that one stick out - there are other lines in this file already
> longer than 80.
Didn't want to add more of these but okay.

> Notwithstanding, I don't see anything wrong with this patch.
> 
> Acked-by: Borislav Petkov <bp@...e.de>
Thanks.

Sebastian