linux-kernel - Re: [PATCH 3/5] perf/arm-ccn: Fix CPU hotplug race avoidance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a09e5e4c-f663-8797-0384-fae493ddf29d@arm.com>
Date:   Tue, 5 Feb 2019 11:38:10 +0000
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     robin.murphy@....com, will.deacon@....com, mark.rutland@....com
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        peterz@...radead.org, tglx@...utronix.de, bigeasy@...utronix.de
Subject: Re: [PATCH 3/5] perf/arm-ccn: Fix CPU hotplug race avoidance



On 04/02/2019 17:09, Robin Murphy wrote:
> Like arm-cci, arm-ccn has the same issue where disabling preemption to
> avoid races between registering the PMU device and the hotplug notifier
> can lead to those operations taking mutexes in an invalid context. Fix
> it the same way by disabling hotplug instead of preemption. Since we
> only ever associate the PMU instance with a single CPU, we can also take
> the opportunity to slightly simplify the hotplug handling to track just
> that CPU number instead of a full cpumask.
> 
> Signed-off-by: Robin Murphy <robin.murphy@....com>

Reviewed-by: Suzuki K Poulse <suzuki.poulose@....com>