linux-kernel - Re: [PATCH] fs/dax: Convert to use vmf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFqt6zYZdpckNPFGx2+nbNs=1UKSGtFvMc5YMvPEnmK4PJyGMQ@mail.gmail.com>
Date:   Tue, 5 Feb 2019 08:03:43 +0530
From:   Souptick Joarder <jrdr.linux@...il.com>
To:     Dan Williams <dan.j.williams@...el.com>
Cc:     Jan Kara <jack@...e.cz>, Matthew Wilcox <willy@...radead.org>,
        Ross Zwisler <zwisler@...nel.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs/dax: Convert to use vmf_error()

Hi Dan,

On Tue, Jan 15, 2019 at 4:00 AM Dan Williams <dan.j.williams@...el.com> wrote:
>
> On Mon, Jan 14, 2019 at 12:59 AM Jan Kara <jack@...e.cz> wrote:
> >
> > On Sat 05-01-19 00:54:11, Souptick Joarder wrote:
> > > This code is converted to use vmf_error().
> > >
> > > Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>
> >
> > Dan, you are merging DAX patches these days. So probably you should add
> > yourself to 'FILESYSTEM DIRECT ACCESS (DAX)' in MAINTAINERs.
>
> Sounds good, I'll merge this and get MAINTAINERs fixed up.

This is not reflecting in linux-next. Is this queued for 5.1 ?

>
> > Or I can start
> > picking patches for fsdax to my tree if you are too busy but I think your
> > tree is easier as there are less chances for conflicts etc.
> >
> > In either case this patch looks OK to me so feel free to add
> >
> > Reviewed-by: Jan Kara <jack@...e.cz>
> >
> >                                                                 Honza
> >
> > > ---
> > >  fs/dax.c | 4 +---
> > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > >
> > > diff --git a/fs/dax.c b/fs/dax.c
> > > index 48132ec..ed39161 100644
> > > --- a/fs/dax.c
> > > +++ b/fs/dax.c
> > > @@ -1220,9 +1220,7 @@ static vm_fault_t dax_fault_return(int error)
> > >  {
> > >       if (error == 0)
> > >               return VM_FAULT_NOPAGE;
> > > -     if (error == -ENOMEM)
> > > -             return VM_FAULT_OOM;
> > > -     return VM_FAULT_SIGBUS;
> > > +     return vmf_error(error);
> > >  }
> > >
> > >  /*
> > > --
> > > 1.9.1
> > >
> > --
> > Jan Kara <jack@...e.com>
> > SUSE Labs, CR