linux-kernel - Re: [PATCH] powerpc/mm: move a KERN_WARNING message to KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ad592bd1-be25-2c3e-50ae-9d31913b9b2d@c-s.fr>
Date:   Tue, 5 Feb 2019 19:11:22 +0100
From:   Christophe Leroy <christophe.leroy@....fr>
To:     Laurent Vivier <lvivier@...hat.com>, linux-kernel@...r.kernel.org
Cc:     linuxppc-dev@...ts.ozlabs.org,
        David Gibson <david@...son.dropbear.id.au>
Subject: Re: [PATCH] powerpc/mm: move a KERN_WARNING message to KERN_DEBUG



Le 05/02/2019 à 19:03, Laurent Vivier a écrit :
> resize_hpt_for_hotplug() reports a warning when it cannot
> increase the hash page table ("Unable to resize hash page
> table to target order") but this is not blocking and
> can make user thinks something has not worked properly.
> 
> If the operation cannot be done the real error message
> will be reported by arch_add_memory() if create_section_mapping()
> fails.
> 
> Signed-off-by: Laurent Vivier <lvivier@...hat.com>
> ---
>   arch/powerpc/mm/hash_utils_64.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c
> index 0cc7fbc3bd1c..b762bdceb510 100644
> --- a/arch/powerpc/mm/hash_utils_64.c
> +++ b/arch/powerpc/mm/hash_utils_64.c
> @@ -778,7 +778,7 @@ void resize_hpt_for_hotplug(unsigned long new_mem_size)
>   
>   		rc = mmu_hash_ops.resize_hpt(target_hpt_shift);
>   		if (rc && (rc != -ENODEV))
> -			printk(KERN_WARNING
> +			printk(KERN_DEBUG

You should use pr_debug() instead.

Christophe

>   			       "Unable to resize hash page table to target order %d: %d\n",
>   			       target_hpt_shift, rc);
>   	}
>