linux-kernel - Re: linux-next: Tree for Feb 5 (btrfs/zstd)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190205182543.GX2900@twin.jikos.cz>
Date:   Tue, 5 Feb 2019 19:25:44 +0100
From:   David Sterba <dsterba@...e.cz>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Btrfs <linux-btrfs@...r.kernel.org>
Subject: Re: linux-next: Tree for Feb 5 (btrfs/zstd)

On Tue, Feb 05, 2019 at 09:40:40AM -0800, Randy Dunlap wrote:
> On 2/4/19 10:12 PM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Changes since 20190204:
> > 
> 
> on i386:
> 
> ../fs/btrfs/zstd.c: In function ‘zstd_reclaim_timer_fn’:
> ../fs/btrfs/zstd.c:27:35: warning: integer overflow in expression [-Woverflow]
>  #define ZSTD_BTRFS_RECLAIM_NS (45 * NSEC_PER_SEC)
>                                    ^
> ../fs/btrfs/zstd.c:96:33: note: in expansion of macro ‘ZSTD_BTRFS_RECLAIM_NS’
>    if (now < victim->last_used + ZSTD_BTRFS_RECLAIM_NS)

Thanks for the report. There's a v2 of the patchset that uses the
timer_after helper and this warning should be gone. The updated version
will appear in for-next soonish.