linux-kernel - preempt.h: some SOFTIRQ_OFFSET should be SOFTIRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Feb 2019 19:34:31 +0100
From:   Denys Vlasenko <vda.linux@...glemail.com>
To:     Frederic Weisbecker <fweisbec@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: preempt.h: some SOFTIRQ_OFFSET should be SOFTIRQ_MASK?

SOFTIRQ is a counter.
Why here:

#define in_serving_softirq()    (softirq_count() & SOFTIRQ_OFFSET)
#define in_task()               (!(preempt_count() & \
                                   (NMI_MASK | HARDIRQ_MASK | SOFTIRQ_OFFSET)))

we check only lowest bit?