linux-kernel - Re: [PATCH] staging: vt6656: Use the correct style for SPDX license Identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190205184431.GD22198@kroah.com>
Date:   Tue, 5 Feb 2019 19:44:31 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Nishad Kamdar <nishadkamdar@...il.com>
Cc:     Forest Bond <forest@...ttletooquiet.net>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vt6656: Use the correct style for SPDX license
 Identifier

On Tue, Feb 05, 2019 at 08:36:24PM +0530, Nishad Kamdar wrote:
> This patch corrects the style for SPDX license Identifier in mac.h
> by using "/* */" in place of "//" as per Linux kernel licensing rules.
> Issue found by checkpatch.
> 
> Signed-off-by: Nishad Kamdar <nishadkamdar@...il.com>
> ---
>  drivers/staging/vt6656/mac.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/vt6656/mac.h b/drivers/staging/vt6656/mac.h
> index 94e700fcd0b6..75166020f7c6 100644
> --- a/drivers/staging/vt6656/mac.h
> +++ b/drivers/staging/vt6656/mac.h
> @@ -1,5 +1,5 @@
> -// SPDX-License-Identifier: GPL-2.0+
> -/*
> +/* SPDX-License-Identifier: GPL-2.0+

Should really be:

/* SPDX-License-Identifier: GPL-2.0+ */

thanks,

greg k-h