linux-kernel - Re: [PATCH] mtd: rawnand: meson: Fix linking error on 32-bit platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190205200641.1c97f9fe@xps13>
Date:   Tue, 5 Feb 2019 20:06:41 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     Liang Yang <liang.yang@...ogic.com>,
        Boris Brezillon <bbrezillon@...nel.org>,
        Richard Weinberger <richard@....at>,
        Kevin Hilman <khilman@...libre.com>,
        linux-mtd@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: rawnand: meson: Fix linking error on 32-bit
 platforms

Hi Nathan,

Nathan Chancellor <natechancellor@...il.com> wrote on Tue, 29 Jan 2019
14:46:57 -0700:

> On arm little endian allyesconfig:
> 
>   ld.lld: error: undefined symbol: __aeabi_uldivmod
>   >>> referenced by meson_nand.c
>   >>> mtd/nand/raw/meson_nand.o:(meson_nfc_setup_data_interface) in archive drivers/built-in.a  
> 
> The dividend tBERS_max is u64, meaning we need to use DIV_ROUND_UP_ULL
> (which wraps do_div) to prevent the compiler from emitting
> __aebi_uldivmod.
> 
> Fixes: 2d570b34b41a ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> ---

Merged in nand/next with the original commit.


Thanks,
Miquèl