[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4aea523a3bc5be0d944f7ed9fadac276b7115002.camel@perches.com>
Date: Tue, 05 Feb 2019 12:18:09 -0800
From: Joe Perches <joe@...ches.com>
To: Eric Dumazet <eric.dumazet@...il.com>,
David Miller <davem@...emloft.net>, thierry.reding@...il.com
Cc: hkallweit1@...il.com, andrew@...n.ch, nic_swsd@...ltek.com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] r8169: Avoid pointer aliasing
On Tue, 2019-02-05 at 12:04 -0800, Eric Dumazet wrote:
>
> On 02/05/2019 10:42 AM, Joe Perches wrote:
> > It's declared after a pointer so it is already is 2 byte aligned.
> >
> > A lot of drivers wouldn't work otherwise.
>
> Maybe these drivers are only used on arches where this does not matter.
Possible.
I had only grepped through the sources looking for
declarations using:
$ git grep -B1 '\[ETH_ALEN\];' -- '*.c' | grep -A1 '\*'
It's quite a few files in net/ too btw.
I still think adding __align(<even#>) is unnecessary here unless
it follows something like a bool or a u8.
Powered by blists - more mailing lists