lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 5 Feb 2019 15:15:16 -0700 From: Jeffrey Hugo <jhugo@...eaurora.org> To: Stephen Boyd <sboyd@...nel.org>, bjorn.andersson@...aro.org, mturquette@...libre.com Cc: marc.w.gonzalez@...e.fr, andy.gross@...aro.org, david.brown@...aro.org, robh+dt@...nel.org, mark.rutland@....com, linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org Subject: Re: [PATCH v1 1/4] clk: qcom: smd: Add XO clock for MSM8998 On 2/5/2019 3:01 PM, Stephen Boyd wrote: > Quoting Jeffrey Hugo (2019-01-30 08:35:44) >> The XO clock generally feeds into other clock controllers as the parent >> for a lot of clock generators. >> >> Fixes: 6131dc81211c (clk: qcom: smd: Add support for MSM8998 rpm clocks) >> Signed-off-by: Jeffrey Hugo <jhugo@...eaurora.org> > > We've historically left out the XO clk because it causes problems where > the XO vote goes away during late init because nobody references it from > the rest of the clk tree and also because RPM defers probe of the system > and then the console blows up when it gets a clk that can't change rate. > See commit 54823af9cd52 ("clk: qcom: Always add factor clock for xo > clocks") for some more info on why we removed all the workarounds and > stuff around here too. > > So are you sure this is OK to do? > > So, I've got pretty much everything as modules, and I haven't seen any issues. However let me take a look at the commit you point out and see. -- Jeffrey Hugo Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
Powered by blists - more mailing lists