linux-kernel - Re: [PATCH 5/5] arm: dts: axpxx: add charge led node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Feb 2019 08:06:10 +0200
From:   Stefan Mavrodiev <stefan@...mex.com>
To:     Chen-Yu Tsai <wens@...e.org>, Stefan Mavrodiev <stefan@...mex.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "open list:X-POWERS MULTIFUNCTION PMIC DEVICE DRIVERS" 
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/5] arm: dts: axpxx: add charge led node


On 2/5/19 6:16 PM, Chen-Yu Tsai wrote:
> On Thu, Jan 31, 2019 at 4:25 PM Stefan Mavrodiev <stefan@...mex.com> wrote:
>> Add dt node for axp20x-led driver controlling CHGLED.
>> Default status is disabled, since it may be not used.
>>
>> Signed-off-by: Stefan Mavrodiev <stefan@...mex.com>
> Please include a cover letter for such a patch series.
Sorry, I will.
>
> Also, do any boards actually use this? I know the Pine64 does, but the
> LED is left to the user to populate. I would really like to have an in
> kernel user of this function, so that we can verify it.

All boards made by Olimex has this led populated. The development and the
testing of the driver was done on A64-OLinuXino board.

Should I make another patch, enabling the LED for the mention board?

Best regards,
Stefan Mavrodiev

>
> ChenYu
>
>> ---
>>   arch/arm/boot/dts/axp209.dtsi | 5 +++++
>>   arch/arm/boot/dts/axp22x.dtsi | 5 +++++
>>   arch/arm/boot/dts/axp81x.dtsi | 5 +++++
>>   3 files changed, 15 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/axp209.dtsi b/arch/arm/boot/dts/axp209.dtsi
>> index 0d9ff12bdf28..f972b6f3ecd0 100644
>> --- a/arch/arm/boot/dts/axp209.dtsi
>> +++ b/arch/arm/boot/dts/axp209.dtsi
>> @@ -69,6 +69,11 @@
>>                  #gpio-cells = <2>;
>>          };
>>
>> +       axp_led: led {
>> +               compatible = "x-powers,axp20x-led";
>> +               status = "disabled";
>> +       };
>> +
>>          battery_power_supply: battery-power-supply {
>>                  compatible = "x-powers,axp209-battery-power-supply";
>>                  status = "disabled";
>> diff --git a/arch/arm/boot/dts/axp22x.dtsi b/arch/arm/boot/dts/axp22x.dtsi
>> index 65a07a67aca9..92a0b64252b1 100644
>> --- a/arch/arm/boot/dts/axp22x.dtsi
>> +++ b/arch/arm/boot/dts/axp22x.dtsi
>> @@ -62,6 +62,11 @@
>>                  #io-channel-cells = <1>;
>>          };
>>
>> +       axp_led: led {
>> +               compatible = "x-powers,axp20x-led";
>> +               status = "disabled";
>> +       };
>> +
>>          battery_power_supply: battery-power-supply {
>>                  compatible = "x-powers,axp221-battery-power-supply";
>>                  status = "disabled";
>> diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boot/dts/axp81x.dtsi
>> index bd83962d3627..22e243cc40d5 100644
>> --- a/arch/arm/boot/dts/axp81x.dtsi
>> +++ b/arch/arm/boot/dts/axp81x.dtsi
>> @@ -74,6 +74,11 @@
>>                  };
>>          };
>>
>> +       axp_led: led {
>> +               compatible = "x-powers,axp20x-led";
>> +               status = "disabled";
>> +       };
>> +
>>          battery_power_supply: battery-power-supply {
>>                  compatible = "x-powers,axp813-battery-power-supply";
>>                  status = "disabled";
>> --
>> 2.17.1
>>