linux-kernel - Re: [PATCH] USB: Fix configuration selection issues introduced in v4.20.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+A=rXE_4q1ioEFTD2iXcS3PLvErXVepZ+uQgj9UW6vKfozxqw@mail.gmail.com>
Date:   Wed, 6 Feb 2019 15:01:45 +0300
From:   Nikolay Yakimov <root@...id.pp.ru>
To:     "Gopal, Saranya" <saranya.gopal@...el.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] USB: Fix configuration selection issues introduced in v4.20.0

Hey there.

Sorry to nag, but it seems we came to the conclusion that there's
indeed a problem with the current code, and then collectively decided
that we're done. Can I do something to expedite this? Are there any
issues with my proposed patch? If there are, what can I do to fix
those? Alternatively, perhaps it would be easier/faster if a bona fide
kernel developer could fix problems described in this thread (well,
actually, I believe we're down to one somewhat pressing problem, which
could be fixed just by moving some code around)

On Thu, 17 Jan 2019 at 06:53, Gopal, Saranya <saranya.gopal@...el.com> wrote:
>
> > The result is this:
> > Before f13912d3f014a, if an RNDIS device has non-vendor-specific
> > configurations after the first one, that one would be selected.
> > After ff2a8c532c14, the first configuration would always be selected
> > for RNDIS devices. Besides, there are several redundant checks in this
> > case, which is, if nothing else, confusing.
> >
> > Hopefully I've explained my point clearly enough.
>
> Agreed. Thanks for pointing it out. I somehow missed this :(
>
> Thanks,
> Saranya