linux-kernel - Re: [PATCH v3 1/2] r8169: Load MAC address from device tree if present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190206123355.GD21676@ulmo>
Date:   Wed, 6 Feb 2019 13:33:55 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     "David S. Miller" <davem@...emloft.net>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Andrew Lunn <andrew@...n.ch>, Joe Perches <joe@...ches.com>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Paul Zimmerman <pauldzim@...il.com>,
        Michal Kubecek <mkubecek@...e.cz>,
        Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] r8169: Load MAC address from device tree if
 present

On Wed, Feb 06, 2019 at 01:30:17PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@...dia.com>
> 
> If the system was booted using a device tree and if the device tree
> contains a MAC address, use it instead of reading one from the EEPROM.
> This is useful in situations where the EEPROM isn't properly programmed
> or where the firmware wants to override the existing MAC address.
> 
> Signed-off-by: Thierry Reding <treding@...dia.com>
> ---
> Applies on net-next.
> 
> Changes in v2:
> - rewrite error check for readability
> - initialize mac_addr array
> 
>  drivers/net/ethernet/realtek/r8169.c | 36 ++++++++++++++++++----------
>  1 file changed, 23 insertions(+), 13 deletions(-)

Sorry, I forgot to include Heiner's Reviewed-by tag here, but with any
luck patchwork will pick it up if I do this:

This patch previously:

Reviewed-by: Heiner Kallweit <hkallweit1@...il.com>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)