linux-kernel - [tip:x86/boot] x86/kexec: Fill in acpi_rsdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-ccec81e4251f5a5421e02874e394338a897056ca@git.kernel.org>
Date:   Wed, 6 Feb 2019 06:37:16 -0800
From:   tip-bot for Kairui Song <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     yannik@...britzki.me, tglx@...utronix.de, dyoung@...hat.com,
        x86@...nel.org, bp@...e.de, prudo@...ux.vnet.ibm.com,
        linux-kernel@...r.kernel.org, takahiro.akashi@...aro.org,
        dhowells@...hat.com, fanc.fnst@...fujitsu.com, bhe@...hat.com,
        akpm@...ux-foundation.org, mingo@...nel.org, hpa@...or.com,
        mingo@...hat.com, kasong@...hat.com
Subject: [tip:x86/boot] x86/kexec: Fill in acpi_rsdp_addr from the first
 kernel

Commit-ID:  ccec81e4251f5a5421e02874e394338a897056ca
Gitweb:     https://git.kernel.org/tip/ccec81e4251f5a5421e02874e394338a897056ca
Author:     Kairui Song <kasong@...hat.com>
AuthorDate: Tue, 5 Feb 2019 01:38:52 +0800
Committer:  Borislav Petkov <bp@...e.de>
CommitDate: Wed, 6 Feb 2019 15:29:03 +0100

x86/kexec: Fill in acpi_rsdp_addr from the first kernel

When efi=noruntime or efi=oldmap is used on the kernel command line, EFI
services won't be available in the second kernel, therefore the second
kernel will not be able to get the ACPI RSDP address from firmware by
calling EFI services and so it won't boot.

Commit

  e6e094e053af ("x86/acpi, x86/boot: Take RSDP address from boot params if available")

added an acpi_rsdp_addr field to boot_params which stores the RSDP
address for other kernel users.

Recently, after

  3a63f70bf4c3 ("x86/boot: Early parse RSDP and save it in boot_params")

the acpi_rsdp_addr will always be filled with a valid RSDP address.

So fill in that value into the second kernel's boot_params thus ensuring
that the second kernel receives the RSDP value from the first kernel.

 [ bp: massage commit message. ]

Signed-off-by: Kairui Song <kasong@...hat.com>
Signed-off-by: Borislav Petkov <bp@...e.de>
Cc: AKASHI Takahiro <takahiro.akashi@...aro.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Baoquan He <bhe@...hat.com>
Cc: Chao Fan <fanc.fnst@...fujitsu.com>
Cc: Dave Young <dyoung@...hat.com>
Cc: David Howells <dhowells@...hat.com>
Cc: "H. Peter Anvin" <hpa@...or.com>
Cc: Ingo Molnar <mingo@...hat.com>
Cc: kexec@...ts.infradead.org
Cc: Philipp Rudo <prudo@...ux.vnet.ibm.com>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: x86-ml <x86@...nel.org>
Cc: Yannik Sembritzki <yannik@...britzki.me>
Link: https://lkml.kernel.org/r/20190204173852.4863-1-kasong@redhat.com
---
 arch/x86/kernel/kexec-bzimage64.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/kexec-bzimage64.c b/arch/x86/kernel/kexec-bzimage64.c
index 0d5efa34f359..2a0ff871025a 100644
--- a/arch/x86/kernel/kexec-bzimage64.c
+++ b/arch/x86/kernel/kexec-bzimage64.c
@@ -215,6 +215,9 @@ setup_boot_parameters(struct kimage *image, struct boot_params *params,
 	params->screen_info.ext_mem_k = 0;
 	params->alt_mem_k = 0;
 
+	/* Always fill in RSDP: it is either 0 or a valid value */
+	params->acpi_rsdp_addr = boot_params.acpi_rsdp_addr;
+
 	/* Default APM info */
 	memset(&params->apm_bios_info, 0, sizeof(params->apm_bios_info));
 
@@ -253,7 +256,6 @@ setup_boot_parameters(struct kimage *image, struct boot_params *params,
 	setup_efi_state(params, params_load_addr, efi_map_offset, efi_map_sz,
 			efi_setup_data_offset);
 #endif
-
 	/* Setup EDD info */
 	memcpy(params->eddbuf, boot_params.eddbuf,
 				EDDMAXNR * sizeof(struct edd_info));