linux-kernel - Re: [PATCH] PM / suspend: measure the time of filesystem syncing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e34a97305c9f40fd510582b4c04ea3839f85e04d.camel@intel.com>
Date:   Wed, 6 Feb 2019 14:52:06 +0000
From:   "Pan, Harry" <harry.pan@...el.com>
To:     "rjw@...ysocki.net" <rjw@...ysocki.net>
CC:     "Brown, Len" <len.brown@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "gs0622@...il.com" <gs0622@...il.com>,
        "pavel@....cz" <pavel@....cz>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
Subject: Re: [PATCH] PM / suspend: measure the time of filesystem syncing

On Tue, 2019-02-05 at 12:55 +0100, Rafael J. Wysocki wrote:
> 
> > +	ktime_t start, end, elapsed;
> 
> Why do you need three vars here?  One should be sufficient.
...
> > +	start = ktime_get_boottime();
> 
> Why _boottime()?
> 
Yes, I agree both comments.

BTW, The initial idea came from processes freezing, apology my sketchy
imitation not considering the context well to choose a proper API.

-Harry