linux-kernel - Re: [PATCH] staging: vt6656: Use the correct style for SPDX license Identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Feb 2019 17:25:24 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Nishad Kamdar <nishadkamdar@...il.com>, devel@...verdev.osuosl.org,
        Forest Bond <forest@...ttletooquiet.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vt6656: Use the correct style for SPDX license
 Identifier

On Tue, Feb 05, 2019 at 10:59:40AM -0800, Joe Perches wrote:
> On Tue, 2019-02-05 at 19:44 +0100, Greg Kroah-Hartman wrote:
> > On Tue, Feb 05, 2019 at 08:36:24PM +0530, Nishad Kamdar wrote:
> > > This patch corrects the style for SPDX license Identifier in mac.h
> > > by using "/* */" in place of "//" as per Linux kernel licensing rules.
> > > Issue found by checkpatch.
> > > 
> > > Signed-off-by: Nishad Kamdar <nishadkamdar@...il.com>
> > > ---
> > >  drivers/staging/vt6656/mac.h | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/staging/vt6656/mac.h b/drivers/staging/vt6656/mac.h
> > > index 94e700fcd0b6..75166020f7c6 100644
> > > --- a/drivers/staging/vt6656/mac.h
> > > +++ b/drivers/staging/vt6656/mac.h
> > > @@ -1,5 +1,5 @@
> > > -// SPDX-License-Identifier: GPL-2.0+
> > > -/*
> > > +/* SPDX-License-Identifier: GPL-2.0+
> > 
> > Should really be:
> > 
> > /* SPDX-License-Identifier: GPL-2.0+ */
> 
> There's a fair number of style inconsistencies in the kernel
> sources for that already.
> 
> ~8% of the .h files that have an 'SPDX-License-Identifier:'
> don't use the recommended style.
> 
> $ git grep -h "SPDX-License" -- '*.h' | \
>   perl -p -e 's@...ntifier:.*\*/*@...ntifier: ... */@; s@...ntifier: [^\.].*@...ntifier:@' | \
>   sort | uniq -c | sort -rn
>    8506 /* SPDX-License-Identifier: ... */
>     593 // SPDX-License-Identifier:
>     154 /* SPDX-License-Identifier:
>      53  * SPDX-License-Identifier:
>       1  * SPDX-License-Identifier:	GPL-2.0
>       1 //SPDX-License-Identifier:
>       1 /*  SPDX-License-Identifier: ... */

Then let's fix them, the documentation says what the correct format is,
there's no reason we can't actually follow what is written...