[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190206164245.GA8466@kroah.com>
Date: Wed, 6 Feb 2019 17:42:45 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Nadav Amit <namit@...are.com>
Cc: Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
Julien Freche <jfreche@...are.com>
Subject: Re: [PATCH 1/6] vmw_balloon: bump version number
On Tue, Feb 05, 2019 at 09:13:31PM -0800, Nadav Amit wrote:
> Following recent changes.
>
> Signed-off-by: Nadav Amit <namit@...are.com>
> ---
> drivers/misc/vmw_balloon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
> index f8240b87df22..7294f305753f 100644
> --- a/drivers/misc/vmw_balloon.c
> +++ b/drivers/misc/vmw_balloon.c
> @@ -34,7 +34,7 @@
>
> MODULE_AUTHOR("VMware, Inc.");
> MODULE_DESCRIPTION("VMware Memory Control (Balloon) Driver");
> -MODULE_VERSION("1.5.0.0-k");
> +MODULE_VERSION("1.6.0.0-k");
Please just drop this pointless line, it means nothing and is always out
of date. It's been removed from many other drivers, and I really don't
want to see it come back.
Your driver "version" is the kernel version, full stop. That's all you
need to ever worry about.
thanks,
greg k-h
Powered by blists - more mailing lists