linux-kernel - Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190206211812.GE13621@localhost.localdomain>
Date:   Wed, 6 Feb 2019 19:18:12 -0200
From:   Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:     Neil Horman <nhorman@...driver.com>
Cc:     Julien Gomes <julien@...sta.com>, netdev@...r.kernel.org,
        linux-sctp@...r.kernel.org, linux-kernel@...r.kernel.org,
        davem@...emloft.net, vyasevich@...il.com, lucien.xin@...il.com
Subject: Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict
 about the option length

On Wed, Feb 06, 2019 at 04:08:27PM -0500, Neil Horman wrote:
> On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes wrote:
> > 
> > 
> > On 2/6/19 12:37 PM, Marcelo Ricardo Leitner wrote:
> > > On Wed, Feb 06, 2019 at 12:14:30PM -0800, Julien Gomes wrote:
> > >> Make sctp_setsockopt_events() able to accept sctp_event_subscribe
> > >> structures longer than the current definitions.
> > >>
> > >> This should prevent unjustified setsockopt() failures due to struct
> > >> sctp_event_subscribe extensions (as in 4.11 and 4.12) when using
> > >> binaries that should be compatible, but were built with later kernel
> > >> uapi headers.
> > > 
> > > Not sure if we support backwards compatibility like this?
> > > 
> > > My issue with this change is that by doing this, application will have
> > > no clue if the new bits were ignored or not and it may think that an
> > > event is enabled while it is not.
> > > 
> > > A workaround would be to do a getsockopt and check the size that was
> > > returned. But then, it might as well use the right struct here in the
> > > first place.
> > > 
> > > I'm seeing current implementation as an implicitly versioned argument:
> > > it will always accept setsockopt calls with an old struct (v4.11 or
> > > v4.12), but if the user tries to use v3 on a v1-only system, it will
> > > be rejected. Pretty much like using a newer setsockopt on an old
> > > system.
> > 
> > With the current implementation, given sources that say are supposed to
> > run on a 4.9 kernel (no use of any newer field added in 4.11 or 4.12),
> What given sources say that?  I understand it might be expected, but this is an
> common concern with setsockopt method on many protocols, it just so happens that
> sctp extends them more than other protocols.
> 
> > we can't rebuild the exact same sources on a 4.19 kernel and still run
> > them on 4.9 without messing with structures re-definition.
> > 
> Right, put another way, we support backward compatibility with older userspace
> applications, but not newer one.  I.e. if you build an application against the
> 4.9 SCTP API, it should work with the 4.19 UAPI, but not vice versa, which it
> seems is like what you are trying to do here.

Was looking for that. Thanks.

> 
> > I understand your point, but this still looks like a sort of uapi
> > breakage to me.
> > 
> > 
> > I also had another way to work-around this in mind, by copying optlen
> > bytes and checking that any additional field (not included in the
> > "current" kernel structure definition) is not set, returning EINVAL in
> > such case to keep a similar to current behavior.
> > The issue with this is that I didn't find a suitable (ie not totally
> > arbitrary such as "twice the existing structure size") upper limit to
> > optlen.
> > 
> There is no real uppper limit to the size of the structure in this case, and
> IIRC this isn't the only sockopt structure that can be exentded for SCTP in this
> way.
> 
> I really don't see a sane way to allow newer userspaces to be compatible with
> older kernels here.  If we were to do it I would suggest moving the
> responsibility for that feature into lksctp-tools, versioning that library such
> that correlary symbols are versioned to translate the application view of the
> socket options structs to the size and format that the running kernel
> undertands.  Note that I'm not really advocating for that, as it seems like a
> fast moving target, but if we were to do it I think that would be the most sane
> way to handle it.

Speaking of that, recent lksctp-tools got some defines to help knowing
which features the available kernel headers have as it now probes if
specific struct members are available or not. Though yeah, it also
wouldn't help in this case, just mentioning it.

> 
> Neil
> 
> > > 
> > >>
> > >> Signed-off-by: Julien Gomes <julien@...sta.com>
> > >> ---
> > >>  net/sctp/socket.c | 2 +-
> > >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > >>
> > >> diff --git a/net/sctp/socket.c b/net/sctp/socket.c
> > >> index 9644bdc8e85c..f9717e2789da 100644
> > >> --- a/net/sctp/socket.c
> > >> +++ b/net/sctp/socket.c
> > >> @@ -2311,7 +2311,7 @@ static int sctp_setsockopt_events(struct sock *sk, char __user *optval,
> > >>  	int i;
> > >>  
> > >>  	if (optlen > sizeof(struct sctp_event_subscribe))
> > >> -		return -EINVAL;
> > >> +		optlen = sizeof(struct sctp_event_subscribe);
> > >>  
> > >>  	if (copy_from_user(&subscribe, optval, optlen))
> > >>  		return -EFAULT;
> > >> -- 
> > >> 2.20.1
> > >>
> > 
> >