linux-kernel - Re: linux-next: build failure after merge of the compiler-attributes tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72k9VSdZzGcRhZn5JYJ8N6_JPStjQKcr4rac=DNrVfDYtw@mail.gmail.com>
Date:   Wed, 6 Feb 2019 22:48:13 +0100
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the compiler-attributes tree

Hi Stephen,

On Wed, Feb 6, 2019 at 10:31 PM Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> Hi Miguel,
>
> After merging the compiler-attributes tree, today's linux-next build
> (arm multi_v7_defconfig) failed like this:
>
> In file included from arch/arm/crypto/aes-neonbs-glue.c:17:
> include/linux/module.h:138:7: error: section of alias 'cleanup_module' must match section of its target
>   void cleanup_module(void) __exit __attribute__((alias(#exitfn)));
>        ^~~~~~~~~~~~~~
> arch/arm/crypto/aes-neonbs-glue.c:433:1: note: in expansion of macro 'module_exit'
>  module_exit(aes_exit);
>  ^~~~~~~~~~~
>
> Caused by commit
>
>   b31ca3fcca36 ("include/linux/module.h: mark init/cleanup_module aliases as __init/exit")
>
> I have used the compiler-attributes tree from next-20190206 for today.

Yeah, sorry about that! I saw it an hour ago from the build bot and
already took out the branch from -next.

I tested the change on a subset of modules before pushing, but it
turns out there are some modules that do not mark their functions with
__init/__exit and that, in turns, makes GCC complain.

I sent a message about it a few minutes ago:
https://lore.kernel.org/lkml/CANiq72=gS7=G6WbZ4jqybMBh44FeF7UeVEfeb1hN8uMAMt_2bw@mail.gmail.com/

Cheers,
Miguel