linux-kernel - Re: [PATCH v6 2/2] rtc: support for the Amlogic Meson RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190206223855.GC4719@piout.net>
Date:   Wed, 6 Feb 2019 23:38:55 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Cc:     linux-amlogic@...ts.infradead.org, linux-rtc@...r.kernel.org,
        a.zummo@...ertech.it, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, ben.dooks@...ethink.co.uk,
        ccaione@...libre.com
Subject: Re: [PATCH v6 2/2] rtc: support for the Amlogic Meson RTC

Hi,

On 19/01/2019 15:43:32+0100, Martin Blumenstingl wrote:
> +static int meson_rtc_probe(struct platform_device *pdev)
> +{
> +	struct nvmem_config meson_rtc_nvmem_config = {
> +		.name = "meson-rtc-regmem",
> +		.word_size = 4,
> +		.stride = 4,
> +		.size = 4 * 4,
> +		.reg_read = meson_rtc_regmem_read,
> +		.reg_write = meson_rtc_regmem_write,

Not much to add but if those registers are battery backed, you could add
.type = NVMEM_TYPE_BATTERY_BACKED,


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com