linux-kernel - Re: [PATCH] xhci: Convert xhci_handshake() to use readl_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63866354-48b8-5787-39de-5c23e7471f6f@linux.intel.com>
Date:   Thu, 7 Feb 2019 10:32:10 +0200
From:   Mathias Nyman <mathias.nyman@...ux.intel.com>
To:     Andrey Smirnov <andrew.smirnov@...il.com>,
        linux-usb@...r.kernel.org
Cc:     Mathias Nyman <mathias.nyman@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xhci: Convert xhci_handshake() to use
 readl_poll_timeout()

On 07.02.2019 02:03, Andrey Smirnov wrote:
> Xhci_handshake() implements the algorithm already captured by
> readl_poll_timeout(). Convert the former to use the latter to avoid
> repetition.

readl_poll_timeout() doesn't really work here as it might sleep.

iopoll.h:

/**
  * readx_poll_timeout - Periodically poll an address until a condition is met or a timeout occurs
  *
...                                                                                                              
  * Returns 0 on success and -ETIMEDOUT upon a timeout. In either
  * case, the last read value at @addr is stored in @val. Must not
  * be called from atomic context if sleep_us or timeout_us are used.

-Mathias