linux-kernel - Re: [PATCH] mfd: tps68470: drop unused MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 7 Feb 2019 09:49:58 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: tps68470: drop unused MODULE_DEVICE_TABLE

On Wed, 06 Feb 2019, Paul Gortmaker wrote:

> The Kconfig currently controlling compilation of this code is:
> 
> drivers/mfd/Kconfig:config MFD_TPS68470
> drivers/mfd/Kconfig:    bool "TI TPS68470 Power Management / LED chips"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Hence we remove the MODULE_DEVICE_TABLE since it is a no-op for
> non-modular code.
> 
> There is no removal of <linux/module.h> here because there isn't one.
> Instead, it is relying on including that implicitly from an ACPI header.
> 
> In cleaning up the ACPI instance of module.h (which also isn't strictly
> needed), then this mfd driver breaks when MODULE_DEVICE_TABLE becomes
> undefined here.
> 
> The easiest dependency solution is to simply defer the ACPI cleanup
> until this change is present in mainline.
> 
> Cc: Lee Jones <lee.jones@...aro.org>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog