linux-kernel - Re: [PATCH] aout: incorrct use of strncpy fixed.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190207102545.GB2414@zn.tnic>
Date:   Thu, 7 Feb 2019 11:25:45 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Derek Robson <robsonde@...il.com>
Cc:     tglx@...utronix.de, mingo@...hat.com, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] aout: incorrct use of strncpy fixed.

On Sat, Feb 02, 2019 at 01:55:12PM +1300, Derek Robson wrote:
> Found a bug with the source / dest length
> updated to have size limit as the size of dest not size or source.
> 
> Signed-off-by: Derek Robson <robsonde@...il.com>
> ---
>  arch/x86/ia32/ia32_aout.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/ia32/ia32_aout.c b/arch/x86/ia32/ia32_aout.c
> index f65b78d32f5e..1e7f71723ee0 100644
> --- a/arch/x86/ia32/ia32_aout.c
> +++ b/arch/x86/ia32/ia32_aout.c
> @@ -157,7 +157,7 @@ static int aout_core_dump(struct coredump_params *cprm)
>  	fs = get_fs();
>  	set_fs(KERNEL_DS);
>  	has_dumped = 1;
> -	strncpy(dump.u_comm, current->comm, sizeof(current->comm));
> +	strncpy(dump.u_comm, current->comm, sizeof(dump.u_comm));

Are you sure this is correct?

>From looking at this, I think there's something else wrong with this
code though.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.