linux-kernel - Re: bcache on XFS: metadata I/O (dirent I/O?) not getting cached at all?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190207022657.GI14116@dastard>
Date:   Thu, 7 Feb 2019 13:26:57 +1100
From:   Dave Chinner <david@...morbit.com>
To:     Andre Noll <maan@...bingen.mpg.de>
Cc:     Nix <nix@...eri.org.uk>, linux-bcache@...r.kernel.org,
        linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org,
        Coly Li <colyli@...e.de>
Subject: Re: bcache on XFS: metadata I/O (dirent I/O?) not getting cached at
 all?

On Thu, Feb 07, 2019 at 01:24:25AM +0100, Andre Noll wrote:
> On Thu, Feb 07, 10:43, Dave Chinner wrote
> > File data readahead: REQ_RAHEAD
> > Metadata readahead: REQ_META | REQ_RAHEAD
> > 
> > drivers/md/bcache/request.c::check_should_bypass():
> > 
> >         /*
> >          * Flag for bypass if the IO is for read-ahead or background,
> >          * unless the read-ahead request is for metadata (eg, for gfs2).
> >          */
> >         if (bio->bi_opf & (REQ_RAHEAD|REQ_BACKGROUND) &&
> >             !(bio->bi_opf & REQ_PRIO))
> >                 goto skip;
> > 
> > bcache needs fixing - it thinks REQ_PRIO means metadata IO. That's
> > wrong - REQ_META means it's metadata IO, and so this is a bcache
> > bug.
> 
> Do you think 752f66a75abad is bad (ha!) and should be reverted?

Yes, that change is just broken. From include/linux/blk_types.h:

	__REQ_META,             /* metadata io request */
	__REQ_PRIO,             /* boost priority in cfq */


i.e. REQ_META means that it is a metadata request, REQ_PRIO means it
is a "high priority" request. Two completely different things, often
combined, but not interchangeable.

So, yeah, that needs to be reverted if you want bcache to function
properly for metadata caching.

Cheers,

Dave.
-- 
Dave Chinner
david@...morbit.com