linux-kernel - Re: [PATCH 23/35] ARM: davinci: cp-intc: use a common prefix for all symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Feb 2019 19:13:45 +0530
From:   Sekhar Nori <nsekhar@...com>
To:     Bartosz Golaszewski <brgl@...ev.pl>,
        Kevin Hilman <khilman@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH 23/35] ARM: davinci: cp-intc: use a common prefix for all
 symbols

On 31/01/19 7:09 PM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> 
> In preparation for moving the driver to drivers/irqchip do some
> cleanup: use a common prefix for all symbols.
> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
> ---
>  arch/arm/mach-davinci/cp_intc.c             | 143 ++++++++++----------
>  arch/arm/mach-davinci/da830.c               |   2 +-
>  arch/arm/mach-davinci/da850.c               |   2 +-
>  arch/arm/mach-davinci/include/mach/common.h |   2 +-
>  4 files changed, 77 insertions(+), 72 deletions(-)

>  /* Enable interrupt */
>  static void cp_intc_unmask_irq(struct irq_data *d)
>  {
> -	cp_intc_write(d->hwirq, CP_INTC_SYS_ENABLE_IDX_SET);
> +	davinci_cp_intc_write(d->hwirq, DAVINCI_CP_INTC_SYS_ENABLE_IDX_SET);
>  }

For consistency, can you please add davinci_ prefix to this function too?

Thanks,
Sekhar