linux-kernel - Re: [PATCH] serial: Add Tegra Combined UART driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190207160801.GA6991@ulmo>
Date:   Thu, 7 Feb 2019 17:08:02 +0100
From:   Thierry Reding <treding@...dia.com>
To:     Guenter Roeck <linux@...ck-us.net>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: Add Tegra Combined UART driver

On Thu, Feb 07, 2019 at 06:39:16AM -0800, Guenter Roeck wrote:
> On Wed, Jan 23, 2019 at 11:28:19AM +0100, Thierry Reding wrote:
> > The Tegra Combined UART (TCU) is a mailbox-based mechanism that allows
> > multiplexing multiple "virtual UARTs" into a single hardware serial
> > port. The TCU is the primary serial port on Tegra194 devices.
> > 
> > Add a TCU driver utilizing the mailbox framework, as the used mailboxes
> > are part of Tegra HSP blocks that are already controlled by the Tegra
> > HSP mailbox driver.
> > 
> > Based on work by  Mikko Perttunen <mperttunen@...dia.com>.
> > 
> > Signed-off-by: Thierry Reding <treding@...dia.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> In case 0day hasn't reported it:
> 
> arm64:allmodconfig:
> 
> ERROR: "mbox_flush" [drivers/tty/serial/tegra-tcu.ko] undefined!
> 
> mbox_flush() isn't exported.

We only ever test TCU as built-in because it's used for the system
console, so I never actually tested this as a module. I sent a fix
for this earlier this week:

	https://lore.kernel.org/patchwork/patch/1038464/

Thanks,
Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)