linux-kernel - Re: [PATCH 16/17] Plug in new special vfree flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16a2ac45ceef5b6f310f816d696ad2ea8df3b45c.camel@intel.com>
Date:   Thu, 7 Feb 2019 17:33:37 +0000
From:   "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
To:     "rostedt@...dmis.org" <rostedt@...dmis.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
        "ard.biesheuvel@...aro.org" <ard.biesheuvel@...aro.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "jeyu@...nel.org" <jeyu@...nel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "nadav.amit@...il.com" <nadav.amit@...il.com>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "Dock, Deneen T" <deneen.t.dock@...el.com>,
        "rusty@...tcorp.com.au" <rusty@...tcorp.com.au>,
        "linux-security-module@...r.kernel.org" 
        <linux-security-module@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "hpa@...or.com" <hpa@...or.com>,
        "kristen@...ux.intel.com" <kristen@...ux.intel.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "linux_dti@...oud.com" <linux_dti@...oud.com>,
        "luto@...nel.org" <luto@...nel.org>,
        "will.deacon@....com" <will.deacon@....com>,
        "bp@...en8.de" <bp@...en8.de>,
        "kernel-hardening@...ts.openwall.com" 
        <kernel-hardening@...ts.openwall.com>,
        "mhiramat@...nel.org" <mhiramat@...nel.org>,
        "ast@...nel.org" <ast@...nel.org>,
        "paulmck@...ux.ibm.com" <paulmck@...ux.ibm.com>
Subject: Re: [PATCH 16/17] Plug in new special vfree flag

On Wed, 2019-02-06 at 11:23 -0500, Steven Rostedt wrote:
> On Wed, 16 Jan 2019 16:32:58 -0800
> Rick Edgecombe <rick.p.edgecombe@...el.com> wrote:
> 
> > Add new flag for handling freeing of special permissioned memory in vmalloc
> > and remove places where memory was set RW before freeing which is no longer
> > needed.
> > 
> > In kprobes, bpf and ftrace this just adds the flag, and removes the now
> > unneeded set_memory_ calls before calling vfree.
> > 
> > In modules, the freeing of init sections is moved to a work queue, since
> > freeing of RO memory is not supported in an interrupt by vmalloc.
> > Instead of call_rcu, it now uses synchronize_rcu() in the work queue.
> > 
> > Cc: Rusty Russell <rusty@...tcorp.com.au>
> > Cc: Masami Hiramatsu <mhiramat@...nel.org>
> > Cc: Daniel Borkmann <daniel@...earbox.net>
> > Cc: Alexei Starovoitov <ast@...nel.org>
> > Cc: Jessica Yu <jeyu@...nel.org>
> > Cc: Steven Rostedt <rostedt@...dmis.org>
> > Cc: Paul E. McKenney <paulmck@...ux.ibm.com>
> > Signed-off-by: Rick Edgecombe <rick.p.edgecombe@...el.com>
> > ---
> >  arch/x86/kernel/ftrace.c       |  6 +--
> 
> For the ftrace code.
> 
> Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
> 
> -- Steve
> 
Thanks!

Rick
> >  arch/x86/kernel/kprobes/core.c |  7 +---
> >  include/linux/filter.h         | 16 ++-----
> >  kernel/bpf/core.c              |  1 -
> >  kernel/module.c                | 77 +++++++++++++++++-----------------
> >  5 files changed, 45 insertions(+), 62 deletions(-)
> >