linux-kernel - Re: [PATCH] net: stmmac: Variable "val" in function sun8i_dwmac_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 07 Feb 2019 09:53:56 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     yzhai003@....edu
Cc:     csong@...ucr.edu, zhiyunq@...ucr.edu, peppe.cavallaro@...com,
        alexandre.torgue@...com, maxime.ripard@...e-electrons.com,
        wens@...e.org, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: stmmac: Variable "val" in function
 sun8i_dwmac_set_syscon() could be uninitialized

From: Yizhuo Zhai <yzhai003@....edu>
Date: Wed, 6 Feb 2019 21:52:15 -0800

> Thanks, but why initialization matters here? Is performance the main
> concern?

Code that is unnecessary is hard to audit.

People will ask "why" is it initialized?  In what situations is the
initialized value of "0" ever used?

You are wasting people's time and energy by writing unnecessary code.