linux-kernel - RE: [PATCH V14 3/5] i2c: tegra: Add DMA support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR12MB339812565AB1C9973A934522C2680@BYAPR12MB3398.namprd12.prod.outlook.com>
Date:   Thu, 7 Feb 2019 19:14:33 +0000
From:   Sowjanya Komatineni <skomatineni@...dia.com>
To:     Dmitry Osipenko <digetx@...il.com>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Mantravadi Karthik <mkarthik@...dia.com>,
        Shardar Mohammed <smohammed@...dia.com>,
        Timo Alho <talho@...dia.com>
CC:     "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>
Subject: RE: [PATCH V14 3/5] i2c: tegra: Add DMA support



> >>>  static const struct tegra_i2c_hw_feature tegra210_i2c_hw = { @@ 
> >>> -980,6 +1302,7 @@ static const struct tegra_i2c_hw_feature tegra210_i2c_hw = {
> >>>  	.has_mst_fifo = false,
> >>>  	.quirks = &tegra_i2c_quirks,
> >>>  	.supports_bus_clear = true,
> >>> +	.has_apb_dma = true,
> >>>  };
> >>
> >> T186 is missed here.
> > 
> > Currently t186 hw feature is not present in existing linux next and device trees use both t186 and t114 compatibles, so t114 is being applies.
> > But dmas are not used for t186 yet.
> > 
> > T186 hw feature is added for first time as part of interface timing and its in patch next to this patch in same series.
> > This is the same from beginning of all these series.
> >
> >>
> >>>  
> >>>  static const struct tegra_i2c_hw_feature tegra194_i2c_hw = { @@ 
> >>> -995,6 +1318,7 @@ static const struct tegra_i2c_hw_feature tegra194_i2c_hw = {
> >>>  	.has_mst_fifo = true,
> >>>  	.quirks = &tegra194_i2c_quirks,
> >>>  	.supports_bus_clear = true,
> >>> +	.has_apb_dma = false,
> >>>  };
> > 
>
> You added "has_apb_dma" for T194 and not T186 in this patch, I happened to notice it only right now. Please, let's be consistent and set the new field for all of the platforms in this patch.

OK, Will move t186 hw feature addition to this path from interface timing to reflect apb dma flag.