linux-kernel - Re: [PATCH] mips: loongson64: remove unreachable(), fix loongson

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MWHPR2201MB127722785DD946B644451072C1680@MWHPR2201MB1277.namprd22.prod.outlook.com>
Date:   Thu, 7 Feb 2019 19:53:23 +0000
From:   Paul Burton <paul.burton@...s.com>
To:     Yifeng Li <tomli@...li.me>
CC:     "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
        Huacai Chen <chenhc@...ote.com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <pburton@...ecomp.com>,
        James Hogan <jhogan@...nel.org>, Yifeng Li <tomli@...li.me>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Aaro Koskinen <aaro.koskinen@....fi>,
        "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>
Subject: Re: [PATCH] mips: loongson64: remove unreachable(),  fix
 loongson_poweroff().

Hello,

Yifeng Li wrote:
> On my Yeeloong 8089, I noticed the machine fails to shutdown
> properly, and often, the function mach_prepare_reboot() is
> unexpectedly executed, thus the machine reboots instead. A
> wait loop is needed to ensure the system is in a well-defined
> state before going down.
> 
> In commit 997e93d4df16 ("MIPS: Hang more efficiently on
> halt/powerdown/restart"), a general superset of the wait loop for all
> platforms is already provided, so we don't need to implement our own.
> 
> This commit simply removes the unreachable() compiler marco after
> mach_prepare_reboot(), thus allowing the execution of machine_hang().
> My test shows that the machine is now able to shutdown successfully.
> 
> Please note that there are two different bugs preventing the machine
> from shutting down, another work-in-progress commit is needed to
> fix a lockup in cpufreq / i8259 driver, please read Reference, this
> commit does not fix that bug.
> 
> Reference: https://lkml.org/lkml/2019/2/5/908
> Signed-off-by: Yifeng Li <tomli@...li.me>

Applied to mips-fixes.

Thanks,
    Paul

[ This message was auto-generated; if you believe anything is incorrect
  then please email paul.burton@...s.com to report it. ]