linux-kernel - Re: [PATCH v1 1/1] iommu/vt-d: Enable PRI only if the device enables PASID.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0faf4f6a5bbd8cbee84aa78c40ab15216c2b8f0e.camel@infradead.org>
Date:   Thu, 07 Feb 2019 20:08:06 +0000
From:   David Woodhouse <dwmw2@...radead.org>
To:     sathyanarayanan.kuppuswamy@...ux.intel.com, joro@...tes.org
Cc:     iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        Jacob Pan <jacob.jun.pan@...ux.intel.com>,
        Ashok Raj <ashok.raj@...el.com>
Subject: Re: [PATCH v1 1/1] iommu/vt-d: Enable PRI only if the device
 enables PASID.

On Thu, 2019-02-07 at 10:44 -0800, sathyanarayanan.kuppuswamy@...ux.intel.com wrote:
> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>
> 
> Intel IOMMU Page Request Services (PRS) only works with devices which
> supports/uses PASID. So enable PRI only if the device also enables
> PASID support. For more details, Please check the implementation of PRQ
> handler(prq_event_thread()) in intel-svm driver.
> 
> Cc: Jacob Pan <jacob.jun.pan@...ux.intel.com>
> Cc: Ashok Raj <ashok.raj@...el.com>
> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>

Hm, that shouldn't be true. PRI and PASID support are orthogonal.

If we get a PRI request without PASID, we should currently report it as
non-serviced which is the right thing to do. We can hook this up to KVM
etc. to actually allow paging of guests with devices attached, *if* the
devices attached to those guests support PRI.

Nothing fundamentally stops us using PRI without PASID support.



Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5174 bytes)