lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 7 Feb 2019 13:03:51 -0800 From: Andrey Smirnov <andrew.smirnov@...il.com> To: Mathias Nyman <mathias.nyman@...ux.intel.com> Cc: linux-usb@...r.kernel.org, Mathias Nyman <mathias.nyman@...el.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-kernel <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] xhci: Convert xhci_handshake() to use readl_poll_timeout() On Thu, Feb 7, 2019 at 12:27 AM Mathias Nyman <mathias.nyman@...ux.intel.com> wrote: > > On 07.02.2019 02:03, Andrey Smirnov wrote: > > Xhci_handshake() implements the algorithm already captured by > > readl_poll_timeout(). Convert the former to use the latter to avoid > > repetition. > > readl_poll_timeout() doesn't really work here as it might sleep. > > iopoll.h: > > /** > * readx_poll_timeout - Periodically poll an address until a condition is met or a timeout occurs > * > ... > * Returns 0 on success and -ETIMEDOUT upon a timeout. In either > * case, the last read value at @addr is stored in @val. Must not > * be called from atomic context if sleep_us or timeout_us are used. > > -Mathias Shoot, missed this part. Will change to readl_poll_timeout_atomic() in v2. Thanks, Andrey Smirnov
Powered by blists - more mailing lists