linux-kernel - Re: [PATCH v6 0/5] drm: minimize drmP.h dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 7 Feb 2019 22:35:53 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Sam Ravnborg <sam@...nborg.org>
Cc:     dri-devel@...ts.freedesktop.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        Hans de Goede <hdegoede@...hat.com>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <maxime.ripard@...tlin.com>,
        Rodrigo Vivi <rodrigo.vivi@...el.com>,
        Sean Paul <sean@...rly.run>, intel-gfx@...ts.freedesktop.org,
        linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 0/5] drm: minimize drmP.h dependencies

On Sat, Jan 26, 2019 at 01:25:22PM +0100, Sam Ravnborg wrote:
> Updated patchset, with merged patches removed, new patches added.
> 
> > From the original mail:
> 
>         - drmP.h is now stripped down to include files
>           and forward declarations.
>         - All header files in include/drm/ no longer include drmP.h.
> 
> The series was made on top of drm-misc-next:
> f1a2a540c86441016ce3dff6590b7a09080871de ("video/hdmi: Add an enum for HDMI packet types")

Entire series applied to drm-misc-next, and this time around nothing new
popped up! Thanks for sticking through this.

Cheers, Daniel

> 
> Build tested using arm and x86, ia64, alpha, sparc32, sparc64
> Included staging/vboxvideo in the build test - which revealed
> the build issues Daniel had identifed
> 
> This series include fixes to i915 as it looks in drm-misc.
> This series also include fixes to stagin/vboxvideo, which I
> expect to be committet to drm-misc due to the final patch
> (drmP.h removal from drm_modeset_helper.h) depending on this patch.
> 
> Daniel - thanks for being paitent and applying this piecemal.
> 
>         Sam
> v6:
> - include fixes to vboxvideo (Daniel)
> - include i915 build fixes
> - revised/new rcar-du patch (lots of new build failures popped up)
> - split updates to drm/*.c file to dedicated patch,
>   to make the final removal patch slimmer
> 
> v5:
> - Rebased on top of drm-misc-next and dropped patches already merged
> - Sorted list of include files where they are touched (Laurent)
> - Collected ack's, reviewed by's
> 
> v4:
> - Rebased on top of drm-misc-next and dropped patches already merged
> - Include build test of kirin (Daniel)
> - Plug drm_util.h into drm-internals.rst (Daniel)
> - Fix kernel-doc syntax in drm_util.h (Daniel)
> - Split removal of drmP.h from drm_modeset_helper.h
>   in smaller patches, to ease the merge process
> 
> v3:
> - Added Acks/Reviewed annotations (thanks!)
> - Add forward of drm_gem_object to drm_framebuffer.h (Noralf)
> - Drop "drm: move DRM_IF_VERSION to drm_internal.h" as it is applied to drm-misc
> - Drop "drm: make drm_file.h self contained" as Jan made a similar patch that was appleid to drm-misc
> - Rebased on top of drm-misc-next
> 
> v2:
> - DRM_SWITCH_POWER as enum (Daniel Vetter)
> - Prefer forward decalration over includes (Laurent Pinchart)
> - Updated drm_device to use kerneldoc style (Daniel Vetter)
> - Improved commit messages (David Lechner)
> - Split up patch when removing drmP.h from drm_gem_cma_helper.h
> - rebased on top of drm-misc-next
> - dropped patch already applied
> - added reviewed-by from Laurent Pinchart (Laurent Pinchart)
> - add drm_framebuffer.h patch
> - add kernel-doc comments to drm_util.h
> - moved EXPORT_SYMBOL_FOR_TESTS_ONLY to drm_util.h
> - added note to drmP.h not to add new stuff and not to use in new files
> 
> Sam Ravnborg (5):
>       staging/vboxvideo: prepare for drmP.h removal from drm_modeset_helper.h
>       drm/i915: prepare for drmP.h removal from drm_modeset_helper.h
>       drm/rcar-du: prepare for drmP.h removal from drm_modeset_helper.h
>       drm: prepare for drmP.h removal from drm_modeset_helper.h
>       drm: remove drmP.h from drm_modeset_helper.h
> 
>  drivers/gpu/drm/drm_damage_helper.c       |  1 +
>  drivers/gpu/drm/drm_modeset_helper.c      |  2 ++
>  drivers/gpu/drm/i915/i915_drv.c           |  4 +++-
>  drivers/gpu/drm/i915/intel_atomic.c       |  2 ++
>  drivers/gpu/drm/i915/intel_atomic_plane.c |  2 ++
>  drivers/gpu/drm/i915/intel_display.c      | 29 ++++++++++++++++-------------
>  drivers/gpu/drm/i915/intel_pm.c           |  7 +++++--
>  drivers/gpu/drm/rcar-du/rcar_du_crtc.c    |  3 +++
>  drivers/gpu/drm/rcar-du/rcar_du_drv.c     |  1 +
>  drivers/gpu/drm/rcar-du/rcar_du_kms.c     |  2 ++
>  drivers/gpu/drm/rcar-du/rcar_du_plane.c   |  2 ++
>  drivers/gpu/drm/rcar-du/rcar_du_vsp.c     |  1 +
>  drivers/staging/vboxvideo/vbox_drv.c      |  6 +++++-
>  drivers/staging/vboxvideo/vbox_fb.c       | 18 ++++++++++--------
>  drivers/staging/vboxvideo/vbox_mode.c     |  5 ++++-
>  include/drm/drm_modeset_helper.h          |  6 +++++-
>  16 files changed, 64 insertions(+), 27 deletions(-)

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch