linux-kernel - Re: [PATCH v4 1/2] tpm: Unify the send callback behaviourä

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6a86e3e8-e311-7a0f-585d-3f0435b0143a@linux.ibm.com>
Date:   Fri, 8 Feb 2019 14:27:31 -0500
From:   Stefan Berger <stefanb@...ux.ibm.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc:     linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        Peter Huewe <PeterHuewe@....de>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Stefan Berger <stefanb@...ux.vnet.ibm.com>,
        Alexander Steffen <Alexander.Steffen@...ineon.com>,
        stable@...r.kernel.org
Subject: Re: [PATCH v4 1/2] tpm: Unify the send callback behaviourä

On 2/8/19 2:17 PM, Jarkko Sakkinen wrote:
>
>   */
> if (rc > 0) {
> 	dev_warn(&chip->dev,
> 		 "%s: send(): invalid value %d\n", __func__, rc);
> 	rc = 0;
> }
>
> Should be fairly safe play now.

Unfortuantely it isn't. You seemed to have lost the 
EXPORT_SYMBOL_GPL(tpm_chip_start/stop) and the tpm_chip_start/stop 
around the tpm2_shutdown()...


>
> /Jarkko
>