linux-kernel - [PATCH] Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190208024110.8021-1-allen.lkml@gmail.com>
Date:   Fri,  8 Feb 2019 08:11:10 +0530
From:   Allen <allen.lkml@...il.com>
To:     linux-s390@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Allen Pais <allen.lkml@...il.com>
Subject: [PATCH] Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element.

From: Allen Pais <allen.lkml@...il.com>

This issue was detected with the help of Coccinelle.

Signed-off-by: Allen Pais <allen.lkml@...il.com>
---
 arch/s390/tools/gen_opcode_table.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/s390/tools/gen_opcode_table.c b/arch/s390/tools/gen_opcode_table.c
index a1bc02b29c81..468b70c85f62 100644
--- a/arch/s390/tools/gen_opcode_table.c
+++ b/arch/s390/tools/gen_opcode_table.c
@@ -138,7 +138,7 @@ static struct insn_type *insn_format_to_type(char *format)
 	strcpy(tmp, format);
 	base_format = tmp;
 	base_format = strsep(&base_format, "_");
-	for (i = 0; i < sizeof(insn_type_table) / sizeof(insn_type_table[0]); i++) {
+	for (i = 0; i < ARRAY_SIZE(insn_type_table); i++) {
 		ptr = insn_type_table[i].format;
 		while (*ptr) {
 			if (!strcmp(base_format, *ptr))
-- 
2.19.1