lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 8 Feb 2019 23:24:23 +0200
From:   Oded Gabbay <oded.gabbay@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        Olof Johansson <olof@...om.net>,
        Mike Rapoport <rppt@...ux.ibm.com>, ogabbay@...ana.ai,
        Arnd Bergmann <arnd@...db.de>, Joe Perches <joe@...ches.com>
Subject: Re: [PATCH v3 14/15] habanalabs: add debugfs support

On Fri, Feb 8, 2019 at 2:16 PM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Mon, Feb 04, 2019 at 10:32:53PM +0200, Oded Gabbay wrote:
> > +int __init hl_debugfs_init(void)
> > +{
> > +     hl_debug_root = debugfs_create_dir("habanalabs", NULL);
> > +     if (IS_ERR_OR_NULL(hl_debug_root)) {
> > +             pr_err("can not create debugfs directory\n");
> > +             hl_debug_root = NULL;
> > +             return -ENOMEM;
> > +     }
> > +
> > +     return 0;
> > +}
>
> This function should just be one line:
> void __init hl_debugfs_init(void)
> {
>         hl_debug_root = debugfs_create_dir("habanalabs", NULL);
> }
>
> No need to do anything else, or check anything.
>
Correct, fixed.

> thanks,
>
> greg k-h

Powered by blists - more mailing lists