linux-kernel - Re: [PATCH 07/11] mtd: rawnand: denali: use bool type instead of int where appropriate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Feb 2019 23:11:44 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-mtd@...ts.infradead.org,
        Boris Brezillon <bbrezillon@...nel.org>,
        Brian Norris <computersforpeace@...il.com>,
        linux-kernel@...r.kernel.org, Marek Vasut <marek.vasut@...il.com>,
        Richard Weinberger <richard@....at>,
        David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH 07/11] mtd: rawnand: denali: use bool type instead of
 int where appropriate

Hi Joe,

Joe Perches <joe@...ches.com> wrote on Fri, 08 Feb 2019 01:23:37 -0800:

> On Fri, 2019-02-08 at 17:08 +0900, Masahiro Yamada wrote:
> > Use 'bool' type for some function arguments.
> > 
> >  - write (write or read?)
> >  - raw (the raw access mode or not?)
> > 
> > It is true that denali_nand_info::dma_avail is also boolean, but
> > I am keeping it as 'int' because 'scripts/checkpatch --strict' would
> > report the following:
> > 
> > CHECK: Avoid using bool structure members because of possible alignment issues
> >   - see: https://lkml.org/lkml/2017/11/21/384
> > 
> > I do not think it is a matter here, but I am sticking to the suggestion.  
> 
> just fyi: that suggestion has been removed by:
> 
> commit 7967656ffbfa493f5546c0f18bf8a28f702c4baa
> Author: Jason Gunthorpe <jgg@...pe.ca>
> Date:   Fri Jan 18 15:50:47 2019 -0700
> 
>     coding-style: Clarify the expectations around bool
>     
>     There has been some confusion since checkpatch started warning about bool
>     use in structures, and people have been avoiding using it.
>     
>     Many people feel there is still a legitimate place for bool in structures,
>     so provide some guidance on bool usage derived from the entire thread that
>     spawned the checkpatch warning.
>     
>     Link: https://lkml.kernel.org/r/CA+55aFwVZk1OfB9T2v014PTAKFhtVan_Zj2dOjnCy3x
> 
> 
> 

Interesting, thanks for the link! I will consider this for my ongoing
developments.


Regards,
Miquèl